fakenect: replay index in an endless loop #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the last line has been handled then the index gets closed and any 'prev' state is reset so that the next call to freenect_process_events will re-open the index and start again from the first frame. Since the Kinect camera doesn't normally spontaneously stop this seems like a more natural behaviour. In case there is some use case that would prefer to avoid looping over frames then the previous behaviour can be got by setting FAKENECT_LOOP=0 (or some case variant of 'false', 'off' or 'no') Signed-off-by: Robert Bragg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #531 this splits out my patch for allowing a recording to be replayed in an endless loop.
I currently tend to think it's a good default to replay a recording in a loop (and although it's a change of behaviour, it doesn't seem likely to be one that would cause problems).
In case there is some use case overlooked though that depends on the old behaviour then users can set the environment variable:
FAKENECT_LOOP=0(or some case variant of 'false', 'off' or 'no')