Allow 3rd-party applications to operate in get.php scope #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinmollenhour
approved these changes
Feb 4, 2019
|
I'm not sure I get what this is meant to allow. Could you explain it to me? |
|
get.php avoids loading the full Magento environment by caching a few key pieces of information in |
LeeSaferite
approved these changes
Feb 10, 2019
sreichel
approved these changes
May 22, 2019
colinmollenhour
pushed a commit
that referenced
this pull request
May 22, 2019
|
Also cherry-picked onto 1.9.4.x |
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 22, 2019
…p scope get.php avoids loading the full Magento environment by caching a few key pieces of information in resource_config.json. When this file is present it calls Mage::init with the third and fourth arguments so only Mage_Core is loaded and not the gazillion other extensions. However, some third-party extensions might need to be loaded in order to override core functionality. An example is Thai_S3 which we've been working on integrating. When the media file is missing from the local media directory and it must fetch the file off of S3 it needs to do so using the Thai_S3 rewritten classes but since Magento is initialized with only Mage_Core the Thai/S3/etc/config.xml is never loaded so the rewrites are not in effect. This PR makes the list of extensions which are necessary for get.php to work to be configurable. The list of modules to load is persisted in resource_config.json and then used to inform the partial-init.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Oct 25, 2019
…p scope get.php avoids loading the full Magento environment by caching a few key pieces of information in resource_config.json. When this file is present it calls Mage::init with the third and fourth arguments so only Mage_Core is loaded and not the gazillion other extensions. However, some third-party extensions might need to be loaded in order to override core functionality. An example is Thai_S3 which we've been working on integrating. When the media file is missing from the local media directory and it must fetch the file off of S3 it needs to do so using the Thai_S3 rewritten classes but since Magento is initialized with only Mage_Core the Thai/S3/etc/config.xml is never loaded so the rewrites are not in effect. This PR makes the list of extensions which are necessary for get.php to work to be configurable. The list of modules to load is persisted in resource_config.json and then used to inform the partial-init.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
…p scope get.php avoids loading the full Magento environment by caching a few key pieces of information in resource_config.json. When this file is present it calls Mage::init with the third and fourth arguments so only Mage_Core is loaded and not the gazillion other extensions. However, some third-party extensions might need to be loaded in order to override core functionality. An example is Thai_S3 which we've been working on integrating. When the media file is missing from the local media directory and it must fetch the file off of S3 it needs to do so using the Thai_S3 rewritten classes but since Magento is initialized with only Mage_Core the Thai/S3/etc/config.xml is never loaded so the rewrites are not in effect. This PR makes the list of extensions which are necessary for get.php to work to be configurable. The list of modules to load is persisted in resource_config.json and then used to inform the partial-init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it might be useful to allow third-party modules to operate in the get.php scope. To accommodate this, a configuration point called 'loaded_modules' is added, into which third-party modules may register, thereby allowing their classes to be loaded during requests to get.php.