Use SafeERC20.forceApprove in safeIncreaseAllowance and safeDecreaseAllowance #4260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7c28604 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
16 tasks
ernestognw
previously approved these changes
May 18, 2023
Member
ernestognw
left a comment
ernestognw
left a comment
There was a problem hiding this comment.
LGTM but I think it'll create conflicts with #4258 that will require reapproval. Just let me know
frangio
reviewed
May 19, 2023
Contributor
|
Needs a changeset! |
Co-authored-by: Francisco <[email protected]>
frangio
previously approved these changes
May 19, 2023
ernestognw
approved these changes
May 25, 2023
This was referenced Sep 10, 2024
This was referenced Sep 10, 2024
This was referenced Sep 12, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4258 (comment)
PR Checklist