Skip to content

Update actions/upload-artifact action to v4 #4826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 24, 2025
Merged

Update actions/upload-artifact action to v4 #4826

merged 7 commits into from
Jan 24, 2025

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jan 11, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/upload-artifact action major v3 -> v4

Release Notes

actions/upload-artifact (actions/upload-artifact)

v4

Compare Source

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cc37909

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate
Copy link
Contributor Author

renovate bot commented Jan 11, 2024 •
edited
Loading

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@ernestognw
Copy link
Member

ernestognw commented Jan 11, 2024

I noticed that it may be better to uniquely identify every upload given the recent breaking changes in v4.
This doesn't strictly affect the release-cycle updates in a4b98bc, but it will block the release if we need to re run for some reason.

@ernestognw ernestognw requested a review from Amxx January 11, 2024 22:37
Amxx
Amxx reviewed Jan 12, 2024
View reviewed changes
.github/actions/gas-compare/action.yml Outdated
uses: actions/upload-artifact@v4
with:
name: gasreport
name: gasreport-${{ github.run_id }}-${{ github.run_attempt }}
Copy link
Collaborator

@Amxx Amxx Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be an issue.

The artefact that is uploaded here will later be downloaded by the "Download reference report" job in the same action. This step has no way to know the run_id and run_attempt that created the report.

Copy link
Member

@ernestognw ernestognw Jan 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yes you're right. I think this is breaking the workflow and the package owners don't seem to provide an easy workaround.

Shall we keep @V3 insetad?

Amxx
Amxx reviewed Jan 24, 2025
View reviewed changes
Amxx
Amxx reviewed Jan 24, 2025
View reviewed changes
Amxx
Amxx reviewed Jan 24, 2025
View reviewed changes
Amxx
Amxx reviewed Jan 24, 2025
View reviewed changes
Amxx
Amxx reviewed Jan 24, 2025
View reviewed changes
@Amxx
Copy link
Collaborator

Amxx commented Jan 24, 2025

Updated following the migration guide

using overwrite: true should replicate the v3 behavior

Amxx
Amxx reviewed Jan 24, 2025
View reviewed changes
Amxx
Amxx reviewed Jan 24, 2025
View reviewed changes
@Amxx Amxx requested a review from ernestognw January 24, 2025 09:08
@Amxx Amxx merged commit 7ae222b into master Jan 24, 2025
20 checks passed
@Amxx Amxx deleted the renovate/actions-upload-artifact-4.x branch January 24, 2025 15:31
Dargon789 added a commit to Dargon789/openzeppelin-contracts that referenced this pull request Feb 15, 2025
@Dargon789 @ernestognw
@heueristik @github-actions @Amxx @0xsambugs @arr00 @famouswizard @leopardracer @cairoeth @frangio @0xsimka @voronor @ericglau @rnkrtt @pcaversaccio @renovate @RenanSouza2 @futreall @Marcofann @mdqst @Dimitrolito @donatik27 @Danyylka @Daulox92 @0xbryer @NeoByteXx @sky-coderay @brawncode @vtjl10 @zeevick10 @annwag @Hopium21 @YanVictorSN @ursulabauer @0xmichalis @xdaluca @JSeiferth @dangerousfood
Test CI/CD OpenZeppelin (#7)
9d08a58 
* Update ReentrancyGuardTransient documentation (OpenZeppelin#5417)

* Optimize `MerkleTree` for loops by using `uint256` iterators (OpenZeppelin#5415)

Co-authored-by: Ernesto García <[email protected]>

* Update `_revokeRole` documentation in AccessControl (OpenZeppelin#5321)

Co-authored-by: Ernesto García <[email protected]>

* Merge release-v5.2 branch (OpenZeppelin#5424)

Signed-off-by: Hadrien Croubois <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: Sam Bugs <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Arr00 <[email protected]>
Co-authored-by: wizard <[email protected]>
Co-authored-by: leopardracer <[email protected]>
Co-authored-by: cairo <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Francisco Giordano <[email protected]>
Co-authored-by: Simka <[email protected]>
Co-authored-by: Voronor <[email protected]>

* Add a Calldata library with `emptyBytes` and `emptyString` functions (OpenZeppelin#5422)

Co-authored-by: Ernesto García <[email protected]>

* Update governor docs (OpenZeppelin#5420)

* Add missing `Calldata`, `Bytes`, `CAIP2` and `CAIP10` API references (OpenZeppelin#5428)

* Expose `_isTrustedByTarget` internally in ERC2771Forwarder (OpenZeppelin#5416)

* Update LICENSE (OpenZeppelin#5434)

* Refactor EnumerableSet.behavior.js for reuse in the community repo (OpenZeppelin#5441)

* Replace `overriden` with `overridden` in GovernorCountingOverridable.sol (OpenZeppelin#5446)

Co-authored-by: Arr00 <[email protected]>
Co-authored-by: ernestognw <[email protected]>

* Remove Unnecessary Initialisation of `_paused` (OpenZeppelin#5448)

Co-authored-by: Ernesto García <[email protected]>

* Fix Broken Docs References (OpenZeppelin#5436)

* Update actions/upload-artifact action to v4 (OpenZeppelin#4826)

* Remove unused `setBaseURI` tests (OpenZeppelin#5456)

Co-authored-by: Hadrien Croubois <[email protected]>

* Group typographical errors (OpenZeppelin#5443)

Co-authored-by: futreall <[email protected]>
Co-authored-by: Marco <[email protected]>
Co-authored-by: Dmitry <[email protected]>
Co-authored-by: Dmytrol <[email protected]>
Co-authored-by: Noisy <[email protected]>
Co-authored-by: Danil <[email protected]>
Co-authored-by: CrazyFrog <[email protected]>
Co-authored-by: Bryer <[email protected]>
Co-authored-by: Viktor Pavlik <[email protected]>
Co-authored-by: Skylar Ray <[email protected]>
Co-authored-by: Brawn <[email protected]>
Co-authored-by: fuder.eth <[email protected]>
Co-authored-by: FT <[email protected]>
Co-authored-by: Ann Wagner <[email protected]>
Co-authored-by: Hopium <[email protected]>
Co-authored-by: Arr00 <[email protected]>
Co-authored-by: Hadrien Croubois <[email protected]>

* Fix interface docs ordering and add missing interface (OpenZeppelin#5460)

* Add a governor extension that implements a proposal guardian (OpenZeppelin#5303)

Co-authored-by: Arr00 <[email protected]>
Co-authored-by: Ernesto García <[email protected]>

* Fix the CLI output of formal verification runs (OpenZeppelin#5445)

* Update dependency halmos to v0.2.4 (OpenZeppelin#5461)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Use stable foundry version in CI (OpenZeppelin#5465)

* Add stake management function to ERC4337Utils (OpenZeppelin#5471)

* Add forum badge correct link (OpenZeppelin#5481)

* SafeERC20.trySafeTransfer{,from} (OpenZeppelin#5483)

* Improve promise rejections handling in hardhat/async-test-sanity.js (OpenZeppelin#5429)

Co-authored-by: Arr00 <[email protected]>

* Use slither v0.10.4 (OpenZeppelin#5488)

* Add ERC6909 Implementation along with extensions (OpenZeppelin#5394)

Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: Ernesto García <[email protected]>

* Rename ERC4337Utils ENTRYPOINT to ENTRYPOINT_V07 (OpenZeppelin#5472)

Co-authored-by: Hadrien Croubois <[email protected]>

* Add Bytes32x2Set (OpenZeppelin#5442)

Co-authored-by: Ernesto García <[email protected]>

* Add clear function to Enumerable{Set,Map} (OpenZeppelin#5486)

Co-authored-by: Hadrien Croubois <[email protected]>

* Make set-max-old-space-size.sh compatible with sh (OpenZeppelin#5493)

Co-authored-by: Hadrien Croubois <[email protected]>

* Update FUNDING.json (OpenZeppelin#5496)

Co-authored-by: Hadrien Croubois <[email protected]>

* Update FUNDING.json hierarchy (OpenZeppelin#5500)

Co-authored-by: Hadrien Croubois <[email protected]>

* Test behavior of SignatureChecker against the identity precompile (0x4) (OpenZeppelin#5501)

* Treat code-size warnings as errors (OpenZeppelin#5101)

Co-authored-by: Hadrien Croubois <[email protected]>

* Make `TimelockController` receive function virtual (OpenZeppelin#5506)

Co-authored-by: Arr00 <[email protected]>
Co-authored-by: Hadrien Croubois <[email protected]>

---------

Signed-off-by: Hadrien Croubois <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Michael <[email protected]>
Co-authored-by: Maks <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: Sam Bugs <[email protected]>
Co-authored-by: Arr00 <[email protected]>
Co-authored-by: wizard <[email protected]>
Co-authored-by: leopardracer <[email protected]>
Co-authored-by: cairo <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Francisco Giordano <[email protected]>
Co-authored-by: Simka <[email protected]>
Co-authored-by: Voronor <[email protected]>
Co-authored-by: Eric Lau <[email protected]>
Co-authored-by: planetBoy <[email protected]>
Co-authored-by: sudo rm -rf --no-preserve-root / <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renan Souza <[email protected]>
Co-authored-by: futreall <[email protected]>
Co-authored-by: Marco <[email protected]>
Co-authored-by: Dmitry <[email protected]>
Co-authored-by: Dmytrol <[email protected]>
Co-authored-by: Noisy <[email protected]>
Co-authored-by: Danil <[email protected]>
Co-authored-by: CrazyFrog <[email protected]>
Co-authored-by: Bryer <[email protected]>
Co-authored-by: Viktor Pavlik <[email protected]>
Co-authored-by: Skylar Ray <[email protected]>
Co-authored-by: Brawn <[email protected]>
Co-authored-by: fuder.eth <[email protected]>
Co-authored-by: FT <[email protected]>
Co-authored-by: Ann Wagner <[email protected]>
Co-authored-by: Hopium <[email protected]>
Co-authored-by: Yan Victor SN <[email protected]>
Co-authored-by: Ursula <[email protected]>
Co-authored-by: Michalis Kargakis <[email protected]>
Co-authored-by: luca <[email protected]>
Co-authored-by: Jonas <[email protected]>
Co-authored-by: Joseph Delong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Amxx Amxx Amxx approved these changes

@ernestognw ernestognw ernestognw approved these changes

Assignees

No one assigned

Labels

ignore-changeset

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ernestognw @Amxx