-
Notifications
You must be signed in to change notification settings - Fork 12.3k
Rename SignerERC7702 as SignerEIP7702 #5932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,9 +6,9 @@ import {Account} from "../../../account/Account.sol"; | |
| import {ERC721Holder} from "../../../token/ERC721/utils/ERC721Holder.sol"; | ||
| import {ERC1155Holder} from "../../../token/ERC1155/utils/ERC1155Holder.sol"; | ||
| import {ERC7821} from "../../../account/extensions/draft-ERC7821.sol"; | ||
| import {SignerERC7702} from "../../../utils/cryptography/signers/SignerERC7702.sol"; | ||
| import {SignerEIP7702} from "../../../utils/cryptography/signers/SignerEIP7702.sol"; | ||
|
|
||
| contract MyAccountERC7702 is Account, SignerERC7702, ERC7821, ERC721Holder, ERC1155Holder { | ||
| contract MyAccountERC7702 is Account, SignerEIP7702, ERC7821, ERC721Holder, ERC1155Holder { | ||
|
Comment on lines
+9
to
+11
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainImport fails: SignerEIP7702.sol not found (rename source file). CI error shows this import path doesn’t exist yet. After renaming the signer file to SignerEIP7702.sol (in the signers folder), this will compile. 🏁 Script executed: #!/bin/bash
# Confirm the import target exists after the rename
test -f contracts/utils/cryptography/signers/SignerEIP7702.sol && echo "OK: SignerEIP7702.sol present" || (echo "Missing SignerEIP7702.sol" && exit 1)Length of output: 25 Fix missing import: add or rename SignerEIP7702.sol or update the import contracts/mocks/docs/account/MyAccountERC7702.sol (lines 9-11) imports contracts/utils/cryptography/signers/SignerEIP7702.sol, but that file is missing (local check returned "Missing SignerEIP7702.sol") — either create/rename the signer file at that path or change the import to the correct filename. 🧰 Tools🪛 GitHub Actions: checks[error] 9-9: forge test -vvv: Source 'contracts/utils/cryptography/signers/SignerEIP7702.sol' not found: File not found. Searched the following locations: '/home/runner/work/openzeppelin-contracts/openzeppelin-contracts'. 🪛 GitHub Actions: formal verification[error] 9-9: Source 'contracts/utils/cryptography/signers/SignerEIP7702.sol' not found. 🤖 Prompt for AI Agents |
||
| /// @dev Allows the entry point as an authorized executor. | ||
| function _erc7821AuthorizedExecutor( | ||
| address caller, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import fails: SignerEIP7702.sol not found (rename source file).
Same root cause as other failures: the signer file wasn’t renamed. Rename the source file to SignerEIP7702.sol to unblock compilation.
🧰 Tools
🪛 GitHub Actions: formal verification
[error] 19-19: Source 'contracts/utils/cryptography/signers/SignerEIP7702.sol' not found.
🤖 Prompt for AI Agents