Skip to content

Allow passing short lang code #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2018
Merged

Allow passing short lang code #1428

merged 2 commits into from
Jul 14, 2018

Conversation

troosan
Copy link
Contributor

@troosan troosan commented Jul 14, 2018

Description

Fixes #1415

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)

@troosan troosan added this to the v0.15.0 milestone Jul 14, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 94.777% when pulling 8fa1d4f on troosan:parse_short_lang_code into 9ee99d2 on PHPOffice:develop.

@troosan troosan merged commit fe454db into PHPOffice:develop Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@troosan @coveralls