Unicode:UCD Clarify pod for num() #23007
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonycoz
reviewed
Feb 17, 2025
lib/Unicode/UCD.pm
Outdated
| Because these do not follow modern decimal positional notation, stringing more | ||
| than one of these together doesn't mean what you likely would think it means. | ||
| So, C<num> correctly returns C<undef> if you try. If you add a second | ||
| parameter to get returned to you the initial legal numeric length, it returns |
There was a problem hiding this comment.
If you add a second parameter to get returned to you the initial legal numeric length it returns indicating that to get a numeric value you'd have to stop after just the first character in the string.
This is pretty clumsy.
Maybe:
If you request the length of the valid initial substring in this case, that length would be one, since only the first character represents a valid numeric value.
though I'm not entirely happy with that either.
Add example of how it handles numbers that aren't decimal positional. I thought it would clarify things to expand and correct the flawed example pointed out in GH Perl#23003.
jkeenan
reviewed
May 3, 2025
|
This is a documentation PR only. I chose Rumi because I had recently researched it, and the details were fresh in my mind. There are tests for similar situations already in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add example of how it handles numbers that aren't decimal positional.
I thought it would clarify things to expand and correct the flawed example pointed out in GH #23003.