-
Notifications
You must be signed in to change notification settings - Fork 577
add custom error for 'catch (my $e)' #23228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: blead
Are you sure you want to change the base?
Conversation
Don't you get dependencies in
I changed a message in perly.y just before the regen_perly below:
|
File times before:
after:
|
Looks good otherwise. |
7a52a1d
to
54a93b5
Compare
I've dropped the changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change all looks good, but I think it could do with adding a new test of the new message to t/lib/croak/op
.
Previously, this would produce Can't redeclare "my" in "our" at -e line 1, near "(my" Fixes Perl#23222.
54a93b5
to
6f8434f
Compare
I've added some tests to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This fixes an oversight where
catch (my $e)
would run into generic error code that was not prepared to handlecatch
(and hence complain about redeclaringmy
inour
, likeour (my $x)
).