podcheck.t: Minimize exceptions db entries #23245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jkeenan
previously requested changes
May 3, 2025
This program examines the files in the distribution looking for ones that contain pod. When one is found, it knows that it is safe to link to its NAME. It also maintains a data base that contains two types of entries: 1) known issues; and 2) entries that are safe to link to that are external to the distribution. The latter type includes things like man pages or perl modules not shipped with the core. Commit 1fb05c6 added code to better know that it was safe to link to files containing pod in the distribution. But what happened was that that commit caused all such to be needlessly written out to the data base. That db is supposed to contain things that are exceptions, that can't be found otherwise. It is not intended to have the many entries that get resolved in the normal course of executing this program. This commit solves this by marking the entries it finds normally in parsing as to not be written out to the data base. The data base is regenerated, removing these unnecessary entries that got added in 1fb05c6.
khwilliamson
force-pushed
the
podcheck_regen
branch
from
8f1c0ca to
8730694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cThis program examines the files in the distribution looking for ones that contain pod. When one is found, it knows that it is safe to link to its NAME.
It also maintains a data base that contains two types of entries: 1) known issues; and 2) entries that are safe to link to that are external to the distribution. The latter type includes things like man pages or perl modules not shipped with the core.
Commit 1fb05c6 added code to better know that it was safe to link to files containing pod in the distribution. But what happened was that that commit caused all such to be needlessly written out to the data base. That db is supposed to contain things that are exceptions, that can't be found otherwise. It is not intended to have the many entries that get resolved in the normal course of executing this program.
This commit solves this by marking the entries it finds normally in parsing as to not be written out to the data base. The data base is regenerated, removing these unnecesary entries that got added in 1fb05c6.
This replaces #23231