Win32: eliminate the sys_intern fdpid aka w32_fdpid #23262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevented pretty much all of perlio.h from defining anything, and we need that for the the actual fix.
This includes an old test I wrote for pclose blocking on non-Win32 (which up until this fix used distinct pclose code from Win32) and test code for Perl#4106, which is the main issue being fixed by this patch series.
tonycoz
added
the
defer-next-dev
mohawk2
reviewed
May 6, 2025
This duplicated the PL_fdpid already used by every other platform but didn't handle the transfer done when STD handles were reopened as pipes. Along with re-working win32_pclose() to behave much closer to Perl_my_pclose() from util.c and enabling the PID transfer done for STD handles on Win32, this fixes Perl#4106
tonycoz
force-pushed
the
4106-win32-pclose-more-good
branch
from
982af8e to
183726a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This duplicated the PL_fdpid already used by every other platform but didn't handle the transfer done when STD handles were reopened as pipes.
Along with re-working win32_pclose() to behave much closer to Perl_my_pclose() from util.c and enabling the PID transfer done for STD handles on Win32, this fixes #4106