Skip to content

Attribute Escaping #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
natewiebe13 opened this issue Apr 1, 2021 · 1 comment · Fixed by #26
Closed

Attribute Escaping #20

natewiebe13 opened this issue Apr 1, 2021 · 1 comment · Fixed by #26
Assignees
@natewiebe13
Milestone
v2

Comments

@natewiebe13
Copy link
Collaborator

Ensure we escape things like attribute values to ensure we don't end up with invalid markup. Add a unit test for this as well.
@natewiebe13 natewiebe13 added this to the v2 milestone Apr 1, 2021
@natewiebe13 natewiebe13 mentioned this issue Apr 2, 2021
Merged
@natewiebe13 natewiebe13 self-assigned this Apr 2, 2021
@Pixelrobin
Copy link
Owner

Really good point, I didn't think about this when first implementing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natewiebe13 natewiebe13

Labels
None yet
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

Attribute escaping Pixelrobin/php-feather
2 participants
@natewiebe13 @Pixelrobin