Skip to content

Attribute escaping #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Attribute escaping #26

merged 1 commit into from
Apr 6, 2021

Conversation

natewiebe13
Copy link
Collaborator

Fixes #20

@natewiebe13 natewiebe13 added this to the v2 milestone Apr 2, 2021
@natewiebe13 natewiebe13 self-assigned this Apr 2, 2021
@natewiebe13 natewiebe13 changed the base branch from v1.0 to v2.0 April 2, 2021 02:33
@natewiebe13 natewiebe13 assigned Pixelrobin and unassigned natewiebe13 Apr 2, 2021
@natewiebe13 natewiebe13 requested a review from Pixelrobin April 2, 2021 02:34
@Pixelrobin
Copy link
Owner

Good catch on this! I was originally concerned things like URLs wouldn't work but today I learned that you can escape a url like example.com?foo=bar&boo=baz in a URL and it will still work 😂

@Pixelrobin Pixelrobin merged commit 324c0c0 into v2.0 Apr 6, 2021
@Pixelrobin Pixelrobin deleted the attribute-escaping branch April 6, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute Escaping
2 participants