Package housekeeping #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
natewiebe13
commented
Mar 31, 2021
natewiebe13
commented
- Added a basic editorconfig file to start aligning on a coding standard
- Allow README.md to be included in the dist version. I personally like having these included so I can reference the readme from my IDE
- Gitignored composer.lock. Since this is a library instead of a project, it should be compatible with the requirements we specify in composer.json, so once we add automated testing, we should be testing against multiple versions, not just the ones specified in the lock file
- Added myself as an author as we'll be making a number of changes towards v2
|
This looks good! Very sensible suggestions and it makes sense to add you as an author. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.