Store attributes like icons #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natewiebe13
force-pushed
the
remove-javascript
branch
from
5f8d208 to
2539044
Compare
natewiebe13
force-pushed
the
default-attributes-changes
branch
from
cac74ff to
e73c21c
Compare
Pixelrobin
approved these changes
Apr 8, 2021
|
This looks good. Judging from the PR chain going on here, I think it's best to wait for #34 to be merged into this first before merging into |
|
I was actually planning to do the opposite direction. They are against the other branches as they build on the previous. You'll see that Github automatically changed the base branch once the target branch was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the namespaced constant and use in the same manner as icons