Updated docs #47
Merged
Updated docs #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pixelrobin
requested changes
Oct 10, 2021
There was a problem hiding this comment.
Overall this looks great! This is a lot more concise and clean than it was before. Thanks for your time and contributions.
I added some suggestions on ways I think the documentation could be made a little bit clearer in places. I'm open to feedback on those changes, just some thoughts. After this, I think we're ready to merge v2.0 and publish (at least to an alpha) 🙌.
Co-authored-by: Michael Savchuk <[email protected]>
Closed
|
Thanks for the feedback, looks great to me. Going to merge and release v2.0 alpha so we can accept any API suggestions before releasing v2.0 proper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Update documentation and create an upgrade doc that includes breaking changes