Skip to content

[TRAVIS] Enable the build of apps. #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

frozar
Copy link
Contributor

@frozar frozar commented Sep 27, 2017

More tests in Travis CI.

@SergioRAgostinho SergioRAgostinho merged commit cc6699e into PointCloudLibrary:master Sep 27, 2017
@taketwo
Copy link
Member

taketwo commented Sep 28, 2017

That was on the edge of 70 minutes!

@frozar
Copy link
Contributor Author

frozar commented Sep 28, 2017

Continous integration is definitely an issue for PCL. Rework has to be done as we know.

@SergioRAgostinho
Copy link
Member

The first build failed on the merge with master 🤦‍♂️

@frozar
Copy link
Contributor Author

frozar commented Sep 28, 2017

For the non regression tests, everything should run without VTK, shouldn't they?

@frozar frozar deleted the enable-apps branch September 28, 2017 14:36
@frozar
Copy link
Contributor Author

frozar commented Sep 28, 2017

On my repository, I created the branch travis_without_vtk on top of master. I just use -DWITH_VTK=OFF to disable vtk. You can see the really promissing results of Travis CI there:
https://travis-ci.org/frozar/pcl/builds/280901244

The build of doc failed (as usual on my repository) and the job test-ext-1 failed also with this output:

95% tests passed, 1 tests failed out of 21

Total Test time (real) =  85.76 sec

The following tests FAILED:
	  4 - io_grabbers (Failed)

@taketwo, @SergioRAgostinho: What do you think about it?

@taketwo
Copy link
Member

taketwo commented Nov 26, 2017

Can we disable "build-apps", or at least some of the apps? It's annoying that every time a build fails I need to open Travis and check "ah, ok, it's build-apps task timed out as usual, no problem".

@SergioRAgostinho
Copy link
Member

Since we're on the edge, why not try to just disable those 4 or 5 I enable explicitly.

As a side comment, last time I checked, refactoring the apps target was a real pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants