Skip to content

Fix adapter configuration set which returns result, but needs to be resources #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2025

Conversation

SteveL-MSFT
Copy link
Member

PR Summary

The problem is that using PS Adapter implicitly means the engine dynamically creates a new configuration that wraps the resource with appropriate adapter (PS7 or WinPS5.1). This gets run which works fine. However, a part of set also performs a get to get the before_state. A get returns the payload as result, however, the actual before_state as defined in the configuration is resources. So the fix is to address this situation where before_state needs to be retrieved at runtime and make it look like a correct set response.

@SteveL-MSFT SteveL-MSFT requested a review from tgauth April 30, 2025 21:47
@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue May 1, 2025
Merged via the queue into PowerShell:main with commit 66047e0 May 1, 2025
4 checks passed
@SteveL-MSFT SteveL-MSFT deleted the implicit-ps-set branch May 1, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants