Fix a few VI edit mode issues #1262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msftrncs
reviewed
Jan 2, 2020
daxian-dbw
changed the title
daxian-dbw
changed the title
|
@msftrncs The PR is ready for re-review. Please take another look when you have time. Thanks! |
|
@SteveL-MSFT If you have time, please help review this PR. I would like to include it in the GA if possible. Thanks! |
SteveL-MSFT
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1258
ViInsertWithDeletechanges the VI mode from command mode to insert mode. It should make the mode change before callingDeleteChar, so the handling ofViEndOfLineFactorinDeleteCharImplwould be correct.Fix #1278
Fix the calculation of how many characters to be deleted in
DeleteCharImpl.Fix #1279
Fix
ViForwardCharso thatRightArrowworks as expected in VI insert mode.Tests to be addedTests are added.