Allow SmartInsertQuote to surround keywords #1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was impossible to type an apostrophe before a keyword with SmartInsertQuote on, now keywords are surrounded correctly. `hasFlag()` requires .net framework 4.0 or .net core
Prevent a failure mode where SmartInsertQuote fails to insert anything if at the start of an extent but token is not a kind SmartInsertQuote is set to wrap.
|
Oops, didn't know you fixed the return statement here. |
daxian-dbw
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it wasn't possible to type an apostrophe before a keyword with SmartInsertQuote on, now keywords are surrounded correctly.
hasFlag()requires .net framework 4.0 or .net core