Skip to content

Update the release build to use ESRP signing and unify the compliance job #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 27, 2020

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Nov 24, 2020

PR Summary

  1. The original PkgES code signing is retiring and we need to move to the ESRP singing.
  2. Move to use the complaince repo to unify the compliance job across PowerShell org.
  3. Move to use stages in the build.
  4. Update .NET SDK version to use the 5.0 RTM SDK.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw
Copy link
Member Author

@adityapatwardhan It's a little easier to review the changes by ignoring the whitespace changes: https://github.com/PowerShell/PSReadLine/pull/1983/files?w=1

@daxian-dbw daxian-dbw merged commit fb5191c into PowerShell:master Nov 27, 2020
@daxian-dbw daxian-dbw deleted the release-build branch November 27, 2020 19:23
@ghost
Copy link

ghost commented Feb 23, 2021

🎉 v2.2.0-beta2 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant