Bugfix for comparing file path name to determine exact match #1817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Utils.cs has GetMetadataFilesFromPath() that is used by the PublishPSResource and LocalServerApiCalls classes.
In that method we find files which match the package name such as the .psd1, .ps1, .nuspec files. It catches file names that match
packageName*
but that includes files that should not be matched. For example, the Az.KeyVault package has 2 .psd1 files:AzKeyVault.psd1
andAz.KeyVault.Extension.psd1
and the latter was getting considered as a valid match. This PR fixes that. Thestring.Compare()
method is already correctly determining if the filename is a correct match so the code to store that file path as a path of interest should happen in that condition set bystring.Compare()
PR Context
Resolves Azure/azure-powershell#27535
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.