Skip to content

Add null host name check in WSMan #11288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2019

Conversation

iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Dec 7, 2019

PR Summary

Add null check for host name before path normalization.

PR Context

Fix #11278

PR Checklist

@iSazonov iSazonov requested a review from PaulHigin December 7, 2019 15:24
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 7, 2019
@iSazonov iSazonov added this to the 7.0.0-rc.1 milestone Dec 7, 2019
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 7, 2019
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT SteveL-MSFT assigned anmenaga and unassigned iSazonov Dec 9, 2019
@anmenaga
Copy link

anmenaga commented Dec 9, 2019

CodeFactor issues are false positives.

@anmenaga anmenaga merged commit 12bf530 into PowerShell:master Dec 9, 2019
@iSazonov iSazonov deleted the fix-null-in-wsman branch December 9, 2019 19:16
@TravisEz13 TravisEz13 modified the milestones: 7.0.0-rc.1, GA-approved Dec 20, 2019
daxian-dbw pushed a commit that referenced this pull request Jan 10, 2020
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WSMan provider throws exception for non-existent path with -PathType Container
7 participants