Skip to content

Mark InitialSessionState.ImportPSSnapIn as Obsolete #11399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Dec 18, 2019

PR Summary

Mark InitialSessionState.ImportPSSnapIn as Obsolete.
InitialSessionState.ImportPSSnapIn attempts to load a custom PSSnapin from the registry. Custom PSSnapin has been deprecated and removed from PowerShell Core for a long time.

I think this PR should be included in GA, so as to prevent (hopefully) dependency on it for 7.0 users.

PR Checklist

@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 18, 2019
@daxian-dbw daxian-dbw added this to the GA-consider milestone Dec 18, 2019
@daxian-dbw
Copy link
Member Author

@PoshChan Please retry windows

@PoshChan
Copy link
Collaborator

@daxian-dbw, successfully started retry of PowerShell-CI-Windows

@adityapatwardhan adityapatwardhan merged commit 19960a7 into PowerShell:master Dec 20, 2019
@daxian-dbw daxian-dbw deleted the obsolete branch January 9, 2020 23:58
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants