Skip to content

Ignore headers with null values in web cmdlets #11424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Dec 23, 2019

PR Summary

Core throws if web header has a null value - it is not valid value.
Before the change web cmdlets thrown with NRE (value.ToString()).
Now we silently ignore such headers.

PR Context

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 23, 2019
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Dec 23, 2019
@ghost ghost assigned TravisEz13 Dec 23, 2019
@SteveL-MSFT
Copy link
Member

Should we also fix the issue with empty string in this PR?

@iSazonov
Copy link
Collaborator Author

@SteveL-MSFT It is another code path. I think we should have different commits.

@TravisEz13 TravisEz13 merged commit e8d472b into PowerShell:master Jan 7, 2020
@iSazonov iSazonov deleted the web-cmdlets-nre branch January 7, 2020 20:26
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants