Skip to content

Remove UTF-8 BOM from text files #11546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jan 9, 2020

PR Summary

Strip UTF-8 BOM from text files

PR Context

PR Checklist

Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test to exclude regression.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jan 10, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Jan 10, 2020
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT
Copy link
Member

@iSazonov a test should be easy to write, but can be separate from this PR

@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Jan 11, 2020
@iSazonov iSazonov merged commit 70d9ed4 into PowerShell:master Jan 11, 2020
@iSazonov iSazonov changed the title Strip Unicode BOM from text files Remove Unicode BOM from text files Jan 11, 2020
@iSazonov
Copy link
Collaborator

@xtqqczze Thanks for your contribution!

@xtqqczze xtqqczze mentioned this pull request Jan 11, 2020
8 tasks
@xtqqczze xtqqczze changed the title Remove Unicode BOM from text files Remove UTF-8 BOM from text files Jan 11, 2020
@xtqqczze xtqqczze deleted the strip-unicode-bom branch January 22, 2020 16:24
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

xtqqczze added a commit to xtqqczze/PowerShell-PowerShell-Native that referenced this pull request Aug 11, 2020
xtqqczze added a commit to xtqqczze/PSScriptAnalyzer that referenced this pull request Aug 29, 2020
xtqqczze added a commit to xtqqczze/PSScriptAnalyzer that referenced this pull request Aug 29, 2020
xtqqczze added a commit to xtqqczze/PSScriptAnalyzer that referenced this pull request Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants