Skip to content

Remove old dead code from FullCLR #11886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Feb 19, 2020

PR Summary

Remove some #if !CORECLR.

  • remove old code from FullCLR time
  • uncomment logging

PR Context

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Feb 19, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Feb 19, 2020
@ghost ghost assigned anmenaga Feb 19, 2020
@@ -233,10 +233,8 @@ protected override void ProcessRecord()
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iSazonov, your last commit had 1 failures in PowerShell-CI-macos
Test-Connection.TraceRoute.TraceRoute works

Expected exactly '10.79.9.114', but got 127.0.0.1.
at <ScriptBlock>, /Users/runner/runners/2.164.8/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 257
257:             $result[0].TargetAddress | Should -BeExactly $realAddress

@iSazonov
Copy link
Collaborator Author

@PoshChan please retry macos

@PoshChan
Copy link
Collaborator

@iSazonov, successfully started retry of PowerShell-CI-macOS

@iSazonov iSazonov closed this Feb 20, 2020
@iSazonov iSazonov reopened this Feb 20, 2020
@iSazonov
Copy link
Collaborator Author

Reopen to restart CIs.

@anmenaga anmenaga merged commit 59ad531 into PowerShell:master Feb 20, 2020
@iSazonov iSazonov deleted the cleanup-coreclr-old branch February 21, 2020 02:55
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants