Skip to content

Conversation

MartinGC94
Copy link
Contributor

Fixes tab completion for help topics on systems without localized help by adding en-US as a fallback.
Get-Help About<Tab>

PR Context

Get-Help will automatically fall back to en-US help topics so the completion for it should do the same.

PR Checklist

Comment on lines 6280 to 6283
Path.Combine(userHelpDir, currentCulture),
Path.Combine(userHelpDir, "en-US"),
Path.Combine(appHelpDir, currentCulture),
Path.Combine(appHelpDir, "en-US")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For discussion:

Suggested change
Path.Combine(userHelpDir, currentCulture),
Path.Combine(userHelpDir, "en-US"),
Path.Combine(appHelpDir, currentCulture),
Path.Combine(appHelpDir, "en-US")
Path.Combine(userHelpDir, currentCulture),
Path.Combine(appHelpDir, currentCulture),
Path.Combine(userHelpDir, "en-US"),
Path.Combine(appHelpDir, "en-US")

Maybe users want to get topics in their language first?

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 20, 2021
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 20, 2021
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Apr 21, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Apr 28, 2021
@ghost
Copy link

ghost commented Apr 28, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan adityapatwardhan merged commit 5d8336a into PowerShell:master May 5, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label May 5, 2021
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.6 milestone May 5, 2021
@adityapatwardhan
Copy link
Member

@MartinGC94 Thank you for your contribution!

@ghost
Copy link

ghost commented May 27, 2021

🎉v7.2.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@MartinGC94 MartinGC94 deleted the FixHelpCompletion branch June 5, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants