-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Take into account ContentType from Headers in WebCmdlets #19227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take into account ContentType from Headers in WebCmdlets #19227
Conversation
test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
Show resolved
Hide resolved
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
@CarloToso Please open new doc issue and add reference in the PR description. |
🎉 Handy links: |
PR Summary
Currently we only check for
-ContentType
and we ignore-Headers @{Content-Type=...}
after this PR we also check for ContentType in headersIf we set both
-ContentType
and-Headers @{Content-Type=...}
-->-ContentType
is usedWe will also have to change the documentation that documents this behaviour
PR Context
Fixes #19156
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).