Remove 'out' in ReadConsole pinvoke

[iSazonov]

PR Summary

Revert change based on the comment #8847 (comment)

PR Context

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Change is not breaking
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
    • Add [feature] to your commit messages if the change is significant or affects feature tests

[daxian-dbw]

Look goo to me.
Can you please update this signature as well: https://github.com/PowerShell/PowerShell/blob/master/src/System.Management.Automation/namespaces/FileSystemProvider.cs#L7082
Should be changed from [return: MarshalAs(UnmanagedType.I1)] to [return: MarshalAs(UnmanagedType.Bool)].

No change is needed as per @jazzdelightsme pointed out below.

[jazzdelightsme]

@daxian-dbw : No! CreateSymbolicLinkW really does return a 1-byte boolean value. (BOOLEAN versus BOOL).

(and I verified this by looking at type information in a debugger; I am very sure)

[daxian-dbw]

@jazzdelightsme Thanks for catching that! Can you please explain a bit more about the difference between BOOLEAN and BOOL in C++?
Is BOOL actually defined as an int in some header files?

[daxian-dbw]

Ha, I might find it -- https://stackoverflow.com/a/6420546/7129704

BOOL is a Microsoft specific type that is defined as an int. You can find it in windef.h

[iSazonov]

@daxian-dbw I see in https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/interop-pinvokes.md#strings that StringBuilder marshalling always re-allocate/re-copy buffers. Make sense review our code to reduce such allocations? Although at first glance I did not see how we could do it.

And the PR fix could be in 6.2.

[daxian-dbw]

Thanks @iSazonov. By reading that guideline, it seems StringBuilder should never be used for P/Invoke as it incurs 4 allocations. I think it make sense to review our uses of it and replace with ArrayPool<char> when appropriate, because we will copy the existing pattern when writing new code. I will take a look at this ReadConsole case in particular.

[iSazonov]

Tracking issue #9139

I will take a look at this ReadConsole case in particular.

Please review my old PR first - it is related :-)

[daxian-dbw]

@iSazonov We are using StringBuilder for the [out] string parameter in P/Invoke almost everywhere.