Remove IsSymLink() P/Invoke on Unix
#9534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
added
the
CL-CodeCleanup
SteveL-MSFT
approved these changes
May 4, 2019
TravisEz13
reviewed
May 6, 2019
|
|
||
| internal static bool NonWindowsIsSymLink(FileSystemInfo fileInfo) | ||
| { | ||
| return Unix.NativeMethods.IsSymLink(fileInfo.FullName); |
There was a problem hiding this comment.
Can we add a comment to the native code as to when this call was removed?
There was a problem hiding this comment.
I could but I don't understand why we need this - in last days we removed some P/Invokes
and earlier a few more without such comments. Perhaps it is more useful to open a tracking issue in PowerShell Native repo.
There was a problem hiding this comment.
A tracking issue would work, but the issue is likely to be open for a long time.
TravisEz13
approved these changes
May 6, 2019
TravisEz13
changed the title
IsSymLink() P/Invoke on Unix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
CoreFX exposes symbolic links (symlink) as reparsepoint https://github.com/dotnet/corefx/blob/87089ef4559605f8a34ca8959a0ef9c71aa1e02e/src/System.IO.FileSystem/src/System/IO/FileStatus.Unix.cs#L81-L82
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.