Skip to content

4103 enhances surface Dice to use subvoxel borders #6681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 5, 2023
Merged

4103 enhances surface Dice to use subvoxel borders #6681

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
eed6f44
enhance surface Dice to use subvoxel areas
wyli Jul 1, 2023
b3a44f4
update docstring
wyli Jul 1, 2023
831c940
py38
wyli Jul 1, 2023
fecc094
simplify
wyli Jul 1, 2023
0fbfa61
update docs
wyli Jul 1, 2023
b8860c1
allow_smaller=False
wyli Jul 2, 2023
05f57aa
Merge branch 'dev' into 4103-surface-based-elements
wyli Jul 2, 2023
8fed8e0
Merge branch 'dev' into 4103-surface-based-elements
wyli Jul 3, 2023
3cb3863
allow_smaller=True
wyli Jul 3, 2023
01ad65d
update based on comments, simplify datatype converting
wyli Jul 4, 2023
9a28579
Merge remote-tracking branch 'upstream/dev' into 4103-surface-based-e…
wyli Jul 4, 2023
c774e92
test gpu
wyli Jul 4, 2023
046b27a
style
wyli Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update docstring 
Signed-off-by: Wenqi Li <[email protected]>
  • Loading branch information
@wyli
wyli committed Jul 1, 2023
commit b3a44f4d253cf77cb64362cf028ccd565f834df6
5 changes: 3 additions & 2 deletions monai/metrics/surface_dice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ class SurfaceDiceMetric(CumulativeIterationMetric):
Computes the Normalized Surface Dice (NSD) for each batch sample and class of
predicted segmentations `y_pred` and corresponding reference segmentations `y` according to equation :eq:`nsd`.
This implementation is based on https://arxiv.org/abs/2111.05408 and supports 2D and 3D images.
Be aware that the computation of boundaries is different from DeepMind's implementation
https://github.com/deepmind/surface-distance. In this implementation, the length/area of a segmentation boundary is
Be aware that by default (`use_subvoxels=False`), the computation of boundaries is different from DeepMind's
mplementation https://github.com/deepmind/surface-distance.
In this implementation, the length/area of a segmentation boundary is
interpreted as the number of its edge pixels. In DeepMind's implementation, the length of a segmentation boundary
depends on the local neighborhood (cf. https://arxiv.org/abs/1809.04430).
This issue is discussed here: https://github.com/Project-MONAI/MONAI/issues/4103.
Expand Down