Skip to content

Adjust subsetting parameters to avoid triggering an error #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025

Conversation

kafitzgerald
Copy link
Contributor

Adjusts bounding box subsetting parameters to avoid returning an empty array that triggers a ValueError (see UXARRAY/uxarray#1285) and causes a CI failure.

Closes #28

Copy link

github-actions bot commented Jun 3, 2025

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: dd8737f
✅ Deployment Preview URL: https://ProjectPythia.github.io/unstructured-grid-viz-cookbook/_preview/30

@kafitzgerald kafitzgerald changed the title Update high-res.ipynb Adjust subsetting parameters to avoid triggering an error Jun 3, 2025
@kafitzgerald
Copy link
Contributor Author

Let me see if I can fix the link checker here as well.

@kafitzgerald
Copy link
Contributor Author

Well, I was able to address one of them (i.e. broken links), but these are still proving problematic:

(notebooks/03-plotting-with-uxarray/customization: line 150003) broken    https://i.postimg.cc/9MqxSYCn/bokeh-1.gif - 502 Server Error: Bad Gateway for url: https://i.postimg.cc/9MqxSYCn/bokeh-1.gif
(notebooks/03-plotting-with-uxarray/customization: line 170002) broken    https://i.postimg.cc/3JpTp2G9/dynamic.gif - 502 Server Error: Bad Gateway for url: https://i.postimg.cc/3JpTp2G9/dynamic.gif

I did log a separate issue for these though.

@kafitzgerald
Copy link
Contributor Author

@philipc2, @erogluorhan - I don't know that I can request reviews on here, but FYI this should fix things with the notebooks.

It looks like the image hosting service is back up as well so the linkcheck will likely pass if we rerun that (I don't have permissions).

@philipc2 philipc2 merged commit 4571a23 into ProjectPythia:main Jun 3, 2025
1 of 2 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 3, 2025
@kafitzgerald kafitzgerald deleted the bounding_box_error branch June 3, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing
2 participants