Skip to content

Changed the default value for max_open_connections to one. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christ0pher wants to merge 3 commits into from
Closed

Changed the default value for max_open_connections to one. #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
043db91
Changed the default value for max_open_connections to one. If the val…
May 12, 2015
ac36f81
Removed the default initialization for database pools. This is import…
May 14, 2015
adeaa64
Polished the final draft for improvements of the initialization of co…
May 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tornado_mysql/pools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

DEBUG = False


def _debug(*msg):
if DEBUG:
print(*msg)
Expand All @@ -31,9 +30,9 @@ class Pool(object):

def __init__(self,
connect_kwargs,
max_idle_connections=1,
max_open_connections,
max_idle_connections=0,
max_recycle_sec=3600,
max_open_connections=0,
io_loop=None,
):
"""
Expand All @@ -47,7 +46,8 @@ def __init__(self,
self.io_loop = io_loop or IOLoop.current()
self.connect_kwargs = connect_kwargs
self.max_idle = max_idle_connections
self.max_open = max_open_connections
if max_open_connections <= 0:
raise ValueError("max idle or open connections not initialized properly")
self.max_recycle_sec = max_recycle_sec

self._opened_conns = 0
Expand All @@ -73,7 +73,7 @@ def _get_conn(self):
return fut

# Open new connection
if self.max_open == 0 or self._opened_conns < self.max_open:
if self._opened_conns < self.max_open:
self._opened_conns += 1
_debug("Creating new connection:", self.stat())
return connect(**self.connect_kwargs)
Expand Down