Enable Swift 3 compatibility mode under Swift 4 #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharplet
force-pushed
the
as-swift-4-swift-3-compat
branch
from
c06dafd to
2f97bcf
Compare
|
Switched to Nimble 7.0.1, hopefully everything is green 🤞 |
|
🍏 📗 💚 🥗 🇬🇱 |
|
Just manually verified that this builds and runs on Xcode 9, although there's a single test failure. 🤔 I don't think that needs to block a patch release though. |
ikesyo
reviewed
Jun 14, 2017
Quick.xcodeproj/project.pbxproj
Outdated
| MACOSX_DEPLOYMENT_TARGET = 10.9; | ||
| METAL_ENABLE_DEBUG_INFO = YES; | ||
| ONLY_ACTIVE_ARCH = YES; | ||
| OTHER_SWIFT_FLAGS = "$(inherited) -swift-version 3"; |
There was a problem hiding this comment.
Can you please remove this since this is not needed (Quick/Nimble#437)?
sharplet
force-pushed
the
as-swift-4-swift-3-compat
branch
from
2f97bcf to
8250d93
Compare
|
I think this should be ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Quick/Nimble#431.
Ideally we should wait for the next Nimble patch release before merging (to avoid pinning
Externals/Nimbleto a branch).