Tmin tmax #678
Merged
Tmin tmax #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checker texture was yet another construct using t0 and t1 to have its own unique meaning. Renaming constructor parameters to be more clear.
A bit more clear.
- Time parameters moved to the end, so it's a more incremental change from the original sphere constructor. - Renamed the constructor time parameters from t0, t1 to time_start, time_end for clarity.
Using ray_tmin and ray_tmax for hit parameters.
|
WAIT. Why doesn't RestOfYourLife have moving_sphere???? That feels like a deliberate choice on our part, was it? |
| double time_start, double time_end) | ||
| : | ||
| center0(ctr0), center1(ctr1), radius(r), mat_ptr(m), | ||
| time0(time_start), time1(time_end) |
There was a problem hiding this comment.
See earlier comments re moving_sphere member variables (time_start and time_end param names may be a bad idea)
|
This PR is absolutely filled with great changes, but see inline |
|
src/TheRestOfYourLife/moving_sphere.h was removed in ac5409b, since it is unused. |
Move camera variables above the scene switch statement, to allow them to also be scene-specific if the user chooses.
- time0 to time_start - time1 to time_end
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #418