Remove by akarnokd, update rules

pmd.xml

@@ -71,7 +71,6 @@
    <rule ref="rulesets/java/basic.xml/DontUseFloatTypeForLoopIndices"/>
    <rule ref="rulesets/java/basic.xml/DoubleCheckedLocking"/>
    <rule ref="rulesets/java/imports.xml/DuplicateImports"/>
-   <rule ref="rulesets/java/empty.xml/EmptyCatchBlock"/>
    <rule ref="rulesets/java/finalizers.xml/EmptyFinalizer"/>
    <rule ref="rulesets/java/empty.xml/EmptyFinallyBlock"/>
    <rule ref="rulesets/java/empty.xml/EmptyInitializer"/>
@@ -179,8 +178,6 @@
    <rule ref="rulesets/java/junit.xml/TestClassWithoutTestCases"/>
    <rule ref="rulesets/java/design.xml/TooFewBranchesForASwitchStatement"/>
    <rule ref="rulesets/java/imports.xml/TooManyStaticImports"/>
-   <rule ref="rulesets/java/design.xml/UncommentedEmptyConstructor"/>
-   <rule ref="rulesets/java/design.xml/UncommentedEmptyMethodBody"/>
    <rule ref="rulesets/java/basic.xml/UnconditionalIfStatement"/>
    <rule ref="rulesets/java/junit.xml/UnnecessaryBooleanAssertion"/>
    <rule ref="rulesets/java/strings.xml/UnnecessaryCaseChange"/>

src/main/java/rx/BackpressureOverflow.java

@@ -25,14 +25,14 @@
 public final class BackpressureOverflow {
 
     /**
-     * By default, signal a MissingBackressureException due to lack of requests.
+     * Signal a MissingBackressureException due to lack of requests.
      */
-    public static final BackpressureOverflow.Strategy ON_OVERFLOW_DEFAULT = Error.INSTANCE;
+    public static final BackpressureOverflow.Strategy ON_OVERFLOW_ERROR = Error.INSTANCE;
 
     /**
-     * Signal a MissingBackressureException due to lack of requests.
+     * By default, signal a MissingBackressureException due to lack of requests.
      */
-    public static final BackpressureOverflow.Strategy ON_OVERFLOW_ERROR = Error.INSTANCE;
+    public static final BackpressureOverflow.Strategy ON_OVERFLOW_DEFAULT = ON_OVERFLOW_ERROR;
 
     /**
      * Drop the oldest value in the buffer.

src/main/java/rx/Completable.java

@@ -379,7 +379,7 @@ public static Completable create(CompletableOnSubscribe onSubscribe) {
         requireNonNull(onSubscribe);
         try {
             return new Completable(onSubscribe);
-        } catch (NullPointerException ex) { // NOPMD by akarnokd on 2016.06.23. 10:54
+        } catch (NullPointerException ex) { // NOPMD 
             throw ex;
         } catch (Throwable ex) {
             RxJavaHooks.onError(ex);
@@ -851,7 +851,7 @@ public static <R> Completable using(final Func0<R> resourceFunc0,
         return create(new CompletableOnSubscribe() {
             @Override
             public void call(final CompletableSubscriber s) {
-                final R resource; // NOPMD by akarnokd on 2016.06.23. 10:55
+                final R resource; // NOPMD 
 
                 try {
                     resource = resourceFunc0.call();
@@ -1549,7 +1549,7 @@ public void call(CompletableSubscriber s) {
                     CompletableSubscriber sw = onLiftDecorated.call(s);
 
                     unsafeSubscribe(sw);
-                } catch (NullPointerException ex) { // NOPMD by akarnokd on 2016.06.23. 10:54
+                } catch (NullPointerException ex) { // NOPMD 
                     throw ex;
                 } catch (Throwable ex) {
                     throw toNpe(ex);
@@ -2007,7 +2007,7 @@ public final void unsafeSubscribe(CompletableSubscriber s) {
             CompletableOnSubscribe onSubscribeDecorated = RxJavaHooks.onCompletableStart(this, this.onSubscribe);
 
             onSubscribeDecorated.call(s);
-        } catch (NullPointerException ex) { // NOPMD by akarnokd on 2016.06.23. 10:54
+        } catch (NullPointerException ex) { // NOPMD 
             throw ex;
         } catch (Throwable ex) {
             Exceptions.throwIfFatal(ex);
@@ -2071,7 +2071,7 @@ public void onSubscribe(Subscription d) {
                 }
             });
             RxJavaHooks.onObservableReturn(s);
-        } catch (NullPointerException ex) { // NOPMD by akarnokd on 2016.06.23. 10:54
+        } catch (NullPointerException ex) { // NOPMD 
             throw ex;
         } catch (Throwable ex) {
             Exceptions.throwIfFatal(ex);

src/main/java/rx/Observable.java

@@ -9015,7 +9015,7 @@ public final Subscription unsafeSubscribe(Subscriber<? super T> subscriber) {
                 // TODO could the hook be the cause of the error in the on error handling.
                 RxJavaHooks.onObservableError(r);
                 // TODO why aren't we throwing the hook's return value.
-                throw r; // NOPMD by akarnokd on 2016.06.23. 10:51
+                throw r; // NOPMD 
             }
             return Subscriptions.unsubscribed();
         }
@@ -9112,7 +9112,7 @@ static <T> Subscription subscribe(Subscriber<? super T> subscriber, Observable<T
                     // TODO could the hook be the cause of the error in the on error handling.
                     RxJavaHooks.onObservableError(r);
                     // TODO why aren't we throwing the hook's return value.
-                    throw r; // NOPMD by akarnokd on 2016.06.23. 10:51
+                    throw r; // NOPMD 
                 }
             }
             return Subscriptions.unsubscribed();

src/main/java/rx/Single.java

@@ -1719,7 +1719,7 @@ public final Subscription unsafeSubscribe(Subscriber<? super T> subscriber) {
                 // TODO could the hook be the cause of the error in the on error handling.
                 RxJavaHooks.onSingleError(r);
                 // TODO why aren't we throwing the hook's return value.
-                throw r; // NOPMD by akarnokd on 2016.06.23. 10:54
+                throw r; // NOPMD 
             }
             return Subscriptions.unsubscribed();
         }
@@ -1829,7 +1829,7 @@ public final Subscription subscribe(Subscriber<? super T> subscriber) {
                 // TODO could the hook be the cause of the error in the on error handling.
                 RxJavaHooks.onSingleError(r);
                 // TODO why aren't we throwing the hook's return value.
-                throw r; // NOPMD by akarnokd on 2016.06.23. 10:53
+                throw r; // NOPMD 
             }
             return Subscriptions.empty();
         }

src/main/java/rx/exceptions/AssemblyStackTraceException.java

@@ -46,7 +46,7 @@ public AssemblyStackTraceException(String message) {
     }
 
     @Override
-    public synchronized Throwable fillInStackTrace() { // NOPMD by akarnokd on 2016.06.23. 10:29
+    public synchronized Throwable fillInStackTrace() { // NOPMD 
         return this;
     }
 }

src/main/java/rx/exceptions/CompositeException.java

@@ -49,7 +49,7 @@ public final class CompositeException extends RuntimeException {
      * @param errors the collection of errors
      * @deprecated please use {@link #CompositeException(Collection)} */
     @Deprecated
-    public CompositeException(String messagePrefix, Collection<? extends Throwable> errors) { // NOPMD by akarnokd on 2016.06.23. 10:31
+    public CompositeException(String messagePrefix, Collection<? extends Throwable> errors) { // NOPMD 
         Set<Throwable> deDupedExceptions = new LinkedHashSet<Throwable>();
         List<Throwable> localExceptions = new ArrayList<Throwable>();
         if (errors != null) {
@@ -119,7 +119,7 @@ public String getMessage() {
     }
 
     @Override
-    public synchronized Throwable getCause() { // NOPMD by akarnokd on 2016.06.23. 10:31
+    public synchronized Throwable getCause() { // NOPMD 
         if (cause == null) {
             // we lazily generate this causal chain if this is called
             CompositeExceptionCausalChain localCause = new CompositeExceptionCausalChain();
@@ -147,7 +147,7 @@ public synchronized Throwable getCause() { // NOPMD by akarnokd on 2016.06.23. 1
                 // we now have 'e' as the last in the chain
                 try {
                     chain.initCause(e);
-                } catch (Throwable t) { // NOPMD by akarnokd on 2016.06.23. 10:32
+                } catch (Throwable t) { // NOPMD 
                     // ignore
                     // the javadocs say that some Throwables (depending on how they're made) will never
                     // let me call initCause without blowing up even if it returns null

src/main/java/rx/exceptions/Exceptions.java

@@ -55,7 +55,7 @@ public static RuntimeException propagate(Throwable t) {
         } else if (t instanceof Error) {
             throw (Error) t;
         } else {
-            throw new RuntimeException(t); // NOPMD by akarnokd on 2016.06.23. 10:29
+            throw new RuntimeException(t); // NOPMD 
         }
     }
     /**
@@ -127,7 +127,7 @@ public static void addCause(Throwable e, Throwable cause) {
         // we now have 'e' as the last in the chain
         try {
             e.initCause(cause);
-        } catch (Throwable t) { // NOPMD by akarnokd on 2016.06.23. 10:30
+        } catch (Throwable t) { // NOPMD 
             // ignore
             // the javadocs say that some Throwables (depending on how they're made) will never
             // let me call initCause without blowing up even if it returns null
@@ -172,7 +172,7 @@ public static void throwIfAny(List<? extends Throwable> exceptions) {
                 } else if (t instanceof Error) {
                     throw (Error) t;
                 } else {
-                    throw new RuntimeException(t); // NOPMD by akarnokd on 2016.06.23. 10:29
+                    throw new RuntimeException(t); // NOPMD 
                 }
             }
             throw new CompositeException(exceptions);

src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java

@@ -75,9 +75,9 @@ final class ResultManager implements Subscription {
         /** Guarded by guard. */
         int rightIds;
         /** Guarded by guard. */
-        final Map<Integer, Observer<T2>> leftMap = new HashMap<Integer, Observer<T2>>(); // NOPMD by akarnokd on 2016.06.23. 12:54
+        final Map<Integer, Observer<T2>> leftMap = new HashMap<Integer, Observer<T2>>(); // NOPMD 
         /** Guarded by guard. */
-        final Map<Integer, T2> rightMap = new HashMap<Integer, T2>(); // NOPMD by akarnokd on 2016.06.23. 12:54
+        final Map<Integer, T2> rightMap = new HashMap<Integer, T2>(); // NOPMD 
         /** Guarded by guard. */
         boolean leftDone;
         /** Guarded by guard. */

src/main/java/rx/internal/operators/OperatorDebounceWithTime.java

@@ -110,7 +110,7 @@ static final class DebounceState<T> {
         /** Guarded by this. */
         boolean emitting;
 
-        public synchronized int next(T value) { // NOPMD by akarnokd on 2016.06.23. 11:30
+        public synchronized int next(T value) { // NOPMD 
             this.value = value;
             this.hasValue = true;
             return ++index;
@@ -173,7 +173,7 @@ public void emitAndComplete(Subscriber<T> onNextAndComplete, Subscriber<?> onErr
             }
             onNextAndComplete.onCompleted();
         }
-        public synchronized void clear() { // NOPMD by akarnokd on 2016.06.23. 11:30
+        public synchronized void clear() { // NOPMD 
             ++index;
             value = null;
             hasValue = false;

src/main/java/rx/internal/operators/OperatorGroupBy.java

@@ -379,7 +379,7 @@ static final class State<T, K> extends AtomicInteger implements Producer, Subscr
         final AtomicBoolean once;
 
 
-        public State(int bufferSize, GroupBySubscriber<?, K, T> parent, K key, boolean delayError) { // NOPMD by akarnokd on 2016.06.23. 12:47
+        public State(int bufferSize, GroupBySubscriber<?, K, T> parent, K key, boolean delayError) { // NOPMD 
             this.queue = new ConcurrentLinkedQueue<Object>();
             this.parent = parent;
             this.key = key;

src/main/java/rx/internal/operators/OperatorPublish.java

@@ -109,7 +109,7 @@ public void call(Subscriber<? super T> child) {
                     // setting the producer will trigger the first request to be considered by 
                     // the subscriber-to-source.
                     child.setProducer(inner);
-                    break; // NOPMD by akarnokd on 2016.06.23. 11:26
+                    break; // NOPMD 
                 }
             }
         };
@@ -194,7 +194,7 @@ public void connect(Action1<? super Subscription> connection) {
             // if connect() was called concurrently, only one of them should actually 
             // connect to the source
             doConnect = !ps.shouldConnect.get() && ps.shouldConnect.compareAndSet(false, true);
-            break; // NOPMD by akarnokd on 2016.06.23. 11:26
+            break; // NOPMD 
         }
         /* 
          * Notify the callback that we have a (new) connection which it can unsubscribe

src/main/java/rx/internal/operators/OperatorReplay.java

@@ -239,7 +239,7 @@ public void call(Subscriber<? super T> child) {
                     // setting the producer will trigger the first request to be considered by 
                     // the subscriber-to-source.
                     child.setProducer(inner);
-                    break; // NOPMD by akarnokd on 2016.06.23. 12:54
+                    break; // NOPMD 
                 }
             }
         };
@@ -279,7 +279,7 @@ public void connect(Action1<? super Subscription> connection) {
             // if connect() was called concurrently, only one of them should actually 
             // connect to the source
             doConnect = !ps.shouldConnect.get() && ps.shouldConnect.compareAndSet(false, true);
-            break; // NOPMD by akarnokd on 2016.06.23. 12:54
+            break; // NOPMD 
         }
         /* 
          * Notify the callback that we have a (new) connection which it can unsubscribe

src/main/java/rx/internal/operators/SingleOnSubscribeUsing.java

@@ -46,7 +46,7 @@ public SingleOnSubscribeUsing(Func0<Resource> resourceFactory,
 
     @Override
     public void call(final SingleSubscriber<? super T> child) {
-        final Resource resource; // NOPMD by akarnokd on 2016.06.23. 11:18
+        final Resource resource; // NOPMD 
 
         try {
             resource = resourceFactory.call();

src/main/java/rx/internal/producers/SingleDelayedProducer.java

@@ -67,7 +67,7 @@ public void request(long n) {
                     emit(child, value);
                 }
             }
-            return; // NOPMD by akarnokd on 2016.06.23. 9:58
+            return; // NOPMD 
         }
     }
 
@@ -85,7 +85,7 @@ public void setValue(T value) {
                     emit(child, value);
                 }
             }
-            return; // NOPMD by akarnokd on 2016.06.23. 9:58
+            return; // NOPMD 
         }
     }
     /**

src/main/java/rx/internal/schedulers/NewThreadWorker.java

@@ -135,7 +135,7 @@ static void purgeExecutors() {
      * @return true if the policy was successfully enabled 
      */
     public static boolean tryEnableCancelPolicy(ScheduledExecutorService executor) {
-        if (SHOULD_TRY_ENABLE_CANCEL_POLICY) { // NOPMD by akarnokd on 2016.06.23. 10:08
+        if (SHOULD_TRY_ENABLE_CANCEL_POLICY) { // NOPMD 
             final boolean isInstanceOfScheduledThreadPoolExecutor = executor instanceof ScheduledThreadPoolExecutor;
 
             Method methodToCall;

src/main/java/rx/internal/util/IndexedRingBuffer.java

@@ -248,7 +248,7 @@ protected IndexedRingBuffer<?> createObject() {
             try {
                 defaultSize = Integer.parseInt(sizeFromProperty);
             } catch (NumberFormatException e) {
-                System.err.println("Failed to set 'rx.indexed-ring-buffer.size' with value " + sizeFromProperty + " => " + e.getMessage()); // NOPMD by akarnokd on 2016.06.23. 11:09
+                System.err.println("Failed to set 'rx.indexed-ring-buffer.size' with value " + sizeFromProperty + " => " + e.getMessage()); // NOPMD 
             }
         }
 
@@ -358,7 +358,7 @@ private ElementSection<E> getElementSection(int index) {
         return a;
     }
 
-    private synchronized int getIndexForAdd() { // NOPMD by akarnokd on 2016.06.23. 11:11
+    private synchronized int getIndexForAdd() { // NOPMD 
         /*
          * Synchronized as I haven't yet figured out a way to do this in an atomic way that doesn't involve object allocation
          */
@@ -387,7 +387,7 @@ private synchronized int getIndexForAdd() { // NOPMD by akarnokd on 2016.06.23.
      * 
      * @return
      */
-    private synchronized int getIndexFromPreviouslyRemoved() { // NOPMD by akarnokd on 2016.06.23. 11:11
+    private synchronized int getIndexFromPreviouslyRemoved() { // NOPMD 
         /*
          * Synchronized as I haven't yet figured out a way to do this in an atomic way that doesn't involve object allocation
          */
@@ -407,7 +407,7 @@ private synchronized int getIndexFromPreviouslyRemoved() { // NOPMD by akarnokd
         }
     }
 
-    private synchronized void pushRemovedIndex(int elementIndex) { // NOPMD by akarnokd on 2016.06.23. 11:11
+    private synchronized void pushRemovedIndex(int elementIndex) { // NOPMD 
         /*
          * Synchronized as I haven't yet figured out a way to do this in an atomic way that doesn't involve object allocation
          */

src/main/java/rx/internal/util/LinkedArrayList.java

@@ -80,14 +80,14 @@ public void add(Object o) {
      * @return the head object array
      */
     public Object[] head() {
-        return head; // NOPMD by akarnokd on 2016.06.23. 11:04
+        return head; // NOPMD 
     }
     /**
      * Returns the tail buffer segment or null if the list is empty.
      * @return the tail object array
      */
     public Object[] tail() {
-        return tail; // NOPMD by akarnokd on 2016.06.23. 11:04
+        return tail; // NOPMD 
     }
     /**
      * Returns the total size of the list.

src/main/java/rx/internal/util/ObjectPool.java

@@ -33,7 +33,7 @@ public abstract class ObjectPool<T> implements SchedulerLifecycle {
     private final AtomicReference<Future<?>> periodicTask;
 
     public ObjectPool() {
-        this(0, 0, 67); // NOPMD by akarnokd on 2016.06.23. 11:00
+        this(0, 0, 67); // NOPMD 
     }
 
     /**

src/main/java/rx/internal/util/OpenHashSet.java

@@ -173,7 +173,7 @@ void rehash() {
 
 
         for (int j = size; j-- != 0; ) {
-            while (a[--i] == null); // NOPMD by akarnokd on 2016.06.23. 11:06
+            while (a[--i] == null); // NOPMD 
             int pos = mix(a[i].hashCode()) & m;
             if (b[pos] != null) {
                 for (;;) {
@@ -205,6 +205,6 @@ public boolean isEmpty() {
      * @return the raw array of values of this set
      */
     public T[] values() {
-        return keys; // NOPMD by akarnokd on 2016.06.23. 11:06
+        return keys; // NOPMD 
     }
 }

src/main/java/rx/internal/util/PlatformDependent.java

@@ -70,7 +70,7 @@ private static int resolveAndroidApiVersion() {
                     .forName("android.os.Build$VERSION", true, getSystemClassLoader())
                     .getField("SDK_INT")
                     .get(null);
-        } catch (Exception e) { // NOPMD by akarnokd on 2016.06.23. 11:04
+        } catch (Exception e) { // NOPMD 
             // Can not resolve version of Android API, maybe current platform is not Android
             // or API of resolving current Version of Android API has changed in some release of Android
             return ANDROID_API_VERSION_IS_NOT_ANDROID;

src/main/java/rx/internal/util/RxJavaPluginUtils.java

@@ -38,8 +38,8 @@ private static void handlePluginException(Throwable pluginException) {
          * Since the plugin should never throw this is a safety net
          * and will complain loudly to System.err so it gets fixed.
          */
-        System.err.println("RxJavaErrorHandler threw an Exception. It shouldn't. => " + pluginException.getMessage()); // NOPMD by akarnokd on 2016.06.23. 11:05
-        pluginException.printStackTrace(); // NOPMD by akarnokd on 2016.06.23. 11:05
+        System.err.println("RxJavaErrorHandler threw an Exception. It shouldn't. => " + pluginException.getMessage()); // NOPMD 
+        pluginException.printStackTrace(); // NOPMD 
     }
 
 }