1.x: exclude some text files from license checks #4093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 80.25%@@ 1.x #4093 diff @@
==========================================
Files 259 259
Lines 16821 16821
Methods 0 0
Messages 0 0
Branches 2554 2554
==========================================
- Hits 13500 13499 -1
+ Misses 2408 2407 -1
- Partials 913 915 +2
|
|
Can we configure it to fail build if some file doesn't have license so we won't forget to add it? // As far as I understand it's license-gradle-plugin. |
|
Yes, but not now as it will fail 2 classes I fixed in another PR. |
|
ok, 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
licenseplugin warns about MDs and text files. In addition, this excluded the JCTools queues and the beta/experimental annotations because they kept their original license header.