1.x: Add Findbugs

[vanniktech]

Continuing from #3164 .

Parsing the generated Findbugs output file it not as trivial as with PMD since it does contain some meta information.

Let me know whether this is wanted or not and if so how it can be pursued.

By default all rules from Findbugs are enabled and one can opt out using excludeFilter = file('findbugs-filter.xml) inside the findbugs block, which will then contain something alone the lines of this.

[akarnokd]

Thanks! I'd like to merge #4091 and #4092 first as rebasing this PR is much easier.

[codecov-io]

Current coverage is 80.28%

Merging #4099 into 1.x will decrease coverage by 0.08%

@@                1.x      #4099   diff @@
==========================================
  Files           258        258          
  Lines         16834      16834          
  Methods           0          0          
  Messages          0          0          
  Branches       2549       2549          
==========================================
- Hits          13529      13515    -14   
- Misses         2400       2408     +8   
- Partials        905        911     +6   

Powered by Codecov. Last updated by d855a29...4af7438

[akarnokd]

Running FindBugs locally shows me 31 problems. Half of them look valid, the other half can be ignored (although I don't see any obvious way of suppressing a warning at a specific source line).

[vanniktech]

Suppressing them is kind of weird AFAIK you can't use @SuppressWarnings, however there's a package, com.google.code.findbugs:annotations:3.0.1 which gives you @SuppressFBWarnings.

[artem-zinnatullin]

Is there an option to suppress them by XML file? (Yeah it's annoying, but
should help).

On Fri, 24 Jun 2016, 01:05 Niklas Baudy, [email protected] wrote:

Suppressing them is kind of weird AFAIK you can't use @SuppressWarnings,
however there's a package, com.google.code.findbugs:annotations:3.0.1
which gives you @SuppressFBWarnings
http://findbugs.sourceforge.net/api/edu/umd/cs/findbugs/annotations/SuppressFBWarnings.html
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#4099 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AA7B3HRx3eid7aXe2iqRvGH99cZzuKP3ks5qOwM2gaJpZM4I9Rdz
.

[vanniktech]

AFAIK you can just use the excludeFilter and then inside ignore certain things (the same way we did it in QualityMatters with Butterknife).

[akarnokd]

Could you rebase this?

[vanniktech]

Done.

[akarnokd]

👍