Skip to content

1.x: provide an explanation why certain tests are ignored #4118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/java/rx/BackpressureTests.java
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ public Observable<Integer> call(Integer i) {
}

@Test
@Ignore // the test is non-deterministic and can't be made deterministic
@Ignore("The test is non-deterministic and can't be made deterministic")
public void testFlatMapAsync() {
int NUM = (int) (RxRingBuffer.SIZE * 2.1);
AtomicInteger c = new AtomicInteger();
Expand Down
3 changes: 1 addition & 2 deletions src/test/java/rx/IntervalDemo.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
import rx.functions.Action0;
import rx.functions.Action1;

@Ignore
// since this doesn't do any automatic testing
@Ignore("Since this doesn't do any automatic testing")
public class IntervalDemo {

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ public void testFlatMapTransformsMaxConcurrentNormal() {
verify(o, never()).onError(any(Throwable.class));
}

@Ignore // don't care for any reordering
@Ignore("Don't care for any reordering")
@Test(timeout = 10000)
public void flatMapRangeAsyncLoop() {
for (int i = 0; i < 2000; i++) {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/rx/observers/SerializedObserverTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ public void onCompleted() {
*
* @throws InterruptedException
*/
@Ignore
@Ignore("Demonstrates thread starvation problem. Read JavaDoc")
@Test
public void testThreadStarvation() throws InterruptedException {

Expand Down