1.x: increase coverage of internal utils, remove unused/unnecessary items #4119
Conversation
Current coverage is 81.17%@@ 1.x #4119 diff @@
==========================================
Files 258 257 -1
Lines 16835 16811 -24
Methods 0 0
Messages 0 0
Branches 2549 2547 -2
==========================================
+ Hits 13569 13647 +78
+ Misses 2350 2266 -84
+ Partials 916 898 -18
|
| @Test | ||
| public void testNotInstantiable() { | ||
| try { | ||
| Constructor<?> c = UtilityFunctions.class.getDeclaredConstructor(); |
There was a problem hiding this comment.
For this we could use https://github.com/pushtorefresh/java-private-constructor-checker from @artem-zinnatullin
There was a problem hiding this comment.
There was a discussion about @artem-zinnatullin 's tool in #3130. The verdict was to not include that depencency. If you want, you can implement a minimalistic method that takes a class, but we don't need the full flexibility.
There was a problem hiding this comment.
Personally I don't see the benefit of recreating that mechanism / check instead of just adding a testCompile dependency. Also Guava was recently added as a test dependency.
There was a problem hiding this comment.
I don't see the benefit of testing this at all. This isn't even a public class! We're testing that an internal type is uninstantiable which has no bearing on the usage of the library and is already enforced by PMD.
Increase coverage of internal utils, remove unused and unnecessary items.