1.x: improve coverage of rx.Observable methods #4178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 83.04%@@ 1.x #4178 diff @@
==========================================
Files 261 261
Lines 16921 16918 -3
Methods 0 0
Messages 0 0
Branches 2554 2555 +1
==========================================
+ Hits 13773 14049 +276
+ Misses 2251 1993 -258
+ Partials 897 876 -21
|
| new FailingObservable().subscribe(ts); | ||
| fail("Should have thrown OnErrorFailedException"); | ||
| } catch (OnErrorFailedException ex) { | ||
| // expected |
There was a problem hiding this comment.
If you really wanted to be comprehensive here you could put TestException in a method local and verify assertSame(ex.getCause(), testException).
There was a problem hiding this comment.
Or just add a message to TestException and assert the cause's message would basically achieve the same thing.
|
lgtm 👍 |
| @@ -10699,14 +10702,14 @@ public final Subscription subscribe(Subscriber<? super T> subscriber) { | |||
| * <dd>The operator doesn't interfere with backpressure which is determined by the source {@code Observable}'s backpressure | |||
| * behavior.</dd> | |||
| * <dt><b>Scheduler:</b></dt> | |||
| * <dd>{@code timeInterval} operates by default on the {@code immediate} {@link Scheduler}.</dd> | |||
| * <dd>{@code timeInterval} operates by default on the {@code computation} {@link Scheduler}.</dd> | |||
There was a problem hiding this comment.
Actually, this operator does not "operate" on the scheduler, it uses it only as source of time
|
Updated. |
|
Thanks for the review. I'm merging this as it may contain the cure for the memory-kill on Travis. Let me know if there are tests that need more tidying up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the coverage of
rx.Observablemethods plusequals()fromTestExceptionas it caused anomalies with deduplication insideCompositeExceptiontimestampandtimeIntervalnow use theSchedulers.computation()as the source for the current time instead ofSchedulers.immediate()which can't be properly hooked. By default, they both returnSystem.currentTimeMillis().