Skip to content

chore(ci): refactor install mdbook code #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore(ci): refactor install mdbook code #14

merged 1 commit into from
Dec 11, 2024

Conversation

@fgimenez
Copy link
Contributor

@fgimenez fgimenez commented Dec 11, 2024

Also some other nits, like aligning on sections format of all workflows and checkout action versions

@fgimenez fgimenez requested review from KolbyML and syjn99 December 11, 2024 12:42
syjn99
syjn99 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@syjn99 syjn99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

KolbyML
KolbyML approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

@fgimenez fgimenez added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit 8c39ed5 Dec 11, 2024
2 checks passed
@fgimenez fgimenez deleted the fgimenez/ci-touchups branch December 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KolbyML KolbyML KolbyML approved these changes

@syjn99 syjn99 syjn99 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fgimenez @KolbyML @syjn99