feat: p2p network init #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please run |
ch4r10t33r
reviewed
Jan 6, 2025
Contributor
ch4r10t33r
left a comment
ch4r10t33r
left a comment
There was a problem hiding this comment.
Few minor comments and questions.
KolbyML
reviewed
Jan 6, 2025
syjn99
reviewed
Jan 7, 2025
Member
syjn99
left a comment
syjn99
left a comment
There was a problem hiding this comment.
Thank you for your effort! I have a question:
What is the goal for this PR? When can we merge those works?
KolbyML
reviewed
Jan 7, 2025
Contributor
There was a problem hiding this comment.
Could this go in the ream-discv5 crate
KolbyML
reviewed
Jan 7, 2025
Contributor
Author
mostly to setup a rough working p2p crate for everyone to start working it. |
KolbyML
reviewed
Jan 10, 2025
Comment on lines
1
to
11
| use discv5::Enr; | ||
|
|
||
| pub struct NetworkConfig { | ||
| pub discv5_config: discv5::Config, | ||
|
|
||
| pub boot_nodes_enr: Vec<Enr>, | ||
|
|
||
| pub disable_discovery: bool, | ||
|
|
||
| pub total_peers: usize, | ||
| } |
Contributor
There was a problem hiding this comment.
can you remove the network-types crate and move NetworkConfig to the discv5 crate after that I believe the PR looks good
looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started with basic stub for p2p network using libp2p. To my assumption most of the p2p layer is going to remain as is and subsequent gossipsub changes for the Beam Chain can be directly added to the upstream. I plan on creating a dummy libp2p network sparsely based on the current networking spec in the beacon chain.