Skip to content

Conversation

@syjn99
Copy link
Member

@syjn99 syjn99 commented Feb 6, 2025

cd testing/ef-tests && make test

Remove mainnet.tar.gz file after extraction, so make the file not managed by git

@syjn99 syjn99 requested a review from KolbyML February 6, 2025 13:27
@syjn99 syjn99 marked this pull request as ready for review February 6, 2025 13:27
@KolbyML
Copy link
Contributor

KolbyML commented Feb 6, 2025

cd testing/ef-tests && make test

As mainnet.tar.gz must not be managed by git, ignore the file.

Doesn't make test delete mainnet.tar.gz?

@syjn99
Copy link
Member Author

syjn99 commented Feb 6, 2025

Doesn't make test delete mainnet.tar.gz?

As make clean is not executed, mainnet.tar.gz remains still in my environment

@KolbyML
Copy link
Contributor

KolbyML commented Feb 6, 2025

instead of changing .gitignore

tar -xzf $(TARGET) -C $(EXTRACT_DIR); \

add rm -f $(TARGET); \

under the linked line

@syjn99 syjn99 force-pushed the chore/ignore-tar-file branch from 1a9e5b3 to 89cb502 Compare February 6, 2025 14:14
@syjn99 syjn99 changed the title chore: add mainnet.tar.gz entry on .gitignore chore(testing): remove target file after extraction Feb 6, 2025
@syjn99
Copy link
Member Author

syjn99 commented Feb 6, 2025

@KolbyML Thanks! Applied

Copy link
Contributor

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

@syjn99 syjn99 added this pull request to the merge queue Feb 6, 2025
Merged via the queue into ReamLabs:master with commit 01334d2 Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants