feat: Implemented the process_registry_updates function #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
approved these changes
Feb 10, 2025
looks good
Comment on lines
1540
to
1543
| let sig = blst::min_pk::Signature::from_bytes(&signed_block.signature.signature) | ||
| .map_err(|err| anyhow!("Unable to retrieve BLS Signature from byets, {:?}", err))?; | ||
| let public_key = PublicKey::from_bytes(&proposer.pubkey.inner) | ||
| .map_err(|err| anyhow!("Unable to convert PublicKey, {:?}", err))?; |
Contributor
There was a problem hiding this comment.
Suggested change
| let sig = blst::min_pk::Signature::from_bytes(&signed_block.signature.signature) | |
| .map_err(|err| anyhow!("Unable to retrieve BLS Signature from byets, {:?}", err))?; | |
| let public_key = PublicKey::from_bytes(&proposer.pubkey.inner) | |
| .map_err(|err| anyhow!("Unable to convert PublicKey, {:?}", err))?; | |
| let sig = blst::min_pk::Signature::from_bytes(&signed_block.signature.signature) | |
| .map_err(|err| anyhow!("Failed to convert signature to BLS Signature type, {err:?}"))?; | |
| let public_key = PublicKey::from_bytes(&proposer.pubkey.inner) | |
| .map_err(|err| anyhow!("Failed to convert pubkey to BLS PublicKey type, {err:?}"))?; |
Comment on lines
1599
to
1601
| let churn_limit = self.get_validator_activation_churn_limit(); | ||
| for i in 0..churn_limit.min(activation_queue.len() as u64) { | ||
| let index = activation_queue[i as usize]; |
Contributor
There was a problem hiding this comment.
Suggested change
| let churn_limit = self.get_validator_activation_churn_limit(); | |
| for i in 0..churn_limit.min(activation_queue.len() as u64) { | |
| let index = activation_queue[i as usize]; | |
| for index in activation_queue[..self.get_validator_activation_churn_limit() as usize] { |
does this week?
Contributor
Author
There was a problem hiding this comment.
it does indeed work
Comment on lines
1602
to
1603
| let validator = &mut self.validators[index]; | ||
| validator.activation_epoch = compute_activation_exit_epoch(current_epoch); |
Contributor
There was a problem hiding this comment.
Suggested change
| let validator = &mut self.validators[index]; | |
| validator.activation_epoch = compute_activation_exit_epoch(current_epoch); | |
| self.validators[index].activation_epoch = compute_activation_exit_epoch(current_epoch); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the process_registry_updates function
https://ethereum.github.io/consensus-specs/specs/deneb/beacon-chain/#registry-updates