Add CentOS (7) checks and feedback in configure script #3637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be used to compare absolute version numbers (integers, perhaps) with version strings Add CentOS (7) vendor check in with Fedora build commands, including some feedback if yum fails on any of the dependencies
| @@ -184,3 +184,34 @@ function GetDistro { | |||
| fi | |||
| export DISTRO | |||
| } | |||
|
|
|||
| function CompareVersionStrings () { | |||
There was a problem hiding this comment.
This code is copypasted from http://stackoverflow.com/questions/4023830/bash-how-compare-two-strings-in-version-format and cannot be used in this project because cc by-sa 3.0 is not compatible with GNU GPLv3. Furthermore, this function is useless for this change and should be removed
added 2 commits
July 1, 2016 09:43
Move CentOS version check to in-line elif statement
|
Apologies, I meant to add a comment - not close the PR. The bash script updates have been made as requested. Please consider this latest PR. |
|
@dave-docnet LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
I speculatively changed the configure script to check for "CentOS" instead of "Fedora", after considering that their base packages share some RHEL inheritance, and the build just worked. Having found though that some dependencies come from the non-standard epel repo, I have also added some checks to ensure that the dep installation from yum succeeds entirely before continuing, while giving some feedback if not.
Commit messages: