ADD: neurodebian freeze interface #240
Conversation
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=========================================
- Coverage 80.95% 80.75% -0.2%
=========================================
Files 33 33
Lines 1512 1533 +21
Branches 156 160 +4
=========================================
+ Hits 1224 1238 +14
- Misses 213 217 +4
- Partials 75 78 +3
Continue to review full report at Codecov.
|
|
@yarikoptic - do you have any comments on this pr? |
| --ndfreeze date=20180312 | ||
| ``` | ||
|
|
||
| The call to `nd_freeze` will occur close to the beginning of the Docker or Singularity specification, regardless of the position of `--ndfreeze` on the command line. |
There was a problem hiding this comment.
might be worth adding a note that it is in effect only for Debian and NeuroDebian (not Ubuntu) APT repositories, since they are the only ones providing snapshots.
| dependencies: | ||
| apt: neurodebian-freeze | ||
| instructions: | | ||
| {{ ndfreeze.install_dependencies() }} |
There was a problem hiding this comment.
I wonder if it could/should be optimized -- nd_freeze will come available pre-installed in NeuroDebian docker base images (very soon hopefully), so in principle no dedicated line to install it would be needed.
Although probably there should be no harm if a dedicated apt-get install of it would be called first... and neurodebian/neurodebian#43 probably would be of no (negative) effect since neurodocker would clean up anyways.
There was a problem hiding this comment.
we can hold off on merging this pr until the neurodebian images are rebuilt, and i'll remove the apt-get install.
There was a problem hiding this comment.
I think they are now:
$> docker pull neurodebian:stretch
stretch: Pulling from library/neurodebian
bc9ab73e5b14: Already exists
b323f9a9fdf6: Already exists
9294e84bac26: Already exists
474b78678a62: Already exists
e955ce81ae0d: Pull complete
Digest: sha256:c3eb8abe2fde32b4333b4fe9efdd698afabf4c49ba07784372710b813c802c8e
Status: Downloaded newer image for neurodebian:stretch
$> docker run -it --rm neurodebian:stretch nd_freeze
Invalid command parameters
USAGE: nd_freeze [--keep-original-apt-sources] datebut that means
- build would fail if ppl have older version of image
- build would not work if base image a stock debian image (which soon will get neurodebian-freeze)
- also might be worth
apt-geting it just to get nd_freeze updated happen we fix things up
So may be let's leave indeed as is for now ;)?
neurodocker/neurodocker.py
Outdated
| " method, and install_path", | ||
| "ndfreeze": | ||
| "Use the NeuroDebian command `nd_freeze` to freeze the apt" | ||
| " sources to a certain date.", |
There was a problem hiding this comment.
again, might be worth adding that of effect only for debian and neurodebian, not ubuntu
|
|
||
| _name = "ndfreeze" | ||
|
|
||
| def __init__(self, date, *args, **kwargs): |
There was a problem hiding this comment.
note that later on we would also add options, at least one, to e.g. force downgrade of already installed packages to the ones available from the snapshots (the last TODO in neurodebian/neurodebian#39 ;))
Co-Authored-By: kaczmarj <[email protected]>
Co-Authored-By: kaczmarj <[email protected]>
|
so IMHO could be merged to claim the victory ;) the rest could be tuned/fixed up later FYI: nd_freeze now, and by default, would try to downgrade any pre-installed packages to the versions available from snapshots to guarantee that even the core installation is reproducible. I guess in some cases some config files (which might be not downgraded) could stick out but hopefully there is nothing like that in base images. |
Closes #238
This pull request proposes adding an interface for neurodebian freeze (
nd_freezeon the command line). This will pin theaptsources in a neurodebian image to a certain date (and optionally time).Usage:
Note that the call to
nd_freezewill happen as early as possible in the Docker or Singularity specification.