Skip to content

Add mamba option to miniconda #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

Shotgunosine
Copy link
Contributor

We're having trouble getting conda to install pandas in a timely fashion over in the freesurfer bids app: bids-apps/freesurfer#67

Adding an option to use the mamba solver with miniconda would solve that for us.

Copy link
Collaborator

@stebo85 stebo85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a great feature :) thank you for the pull request!

@Shotgunosine
Copy link
Contributor Author

Shotgunosine commented Aug 29, 2023

Thanks, @stebo85, any ideas why the linters check is failing? Something about not being able to access the user site-packages directory? Seems like the same error as #561.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 97.43% and no project coverage change.

Comparison is base (a77bcc1) 88.63% compared to head (65cedc2) 88.63%.
Report is 22 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #562   +/-   ##
=======================================
  Coverage   88.63%   88.63%           
=======================================
  Files          11       11           
  Lines        1021     1021           
=======================================
  Hits          905      905           
  Misses        116      116           
Files Changed Coverage Δ
neurodocker/cli/minify/_prune.py 0.00% <0.00%> (ø)
neurodocker/cli/generate.py 91.59% <100.00%> (ø)
neurodocker/cli/minify/trace.py 84.09% <100.00%> (ø)
neurodocker/reproenv/renderers.py 93.06% <100.00%> (ø)
neurodocker/reproenv/state.py 97.29% <100.00%> (ø)
neurodocker/reproenv/template.py 93.51% <100.00%> (ø)
neurodocker/reproenv/types.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stebo85 stebo85 merged commit bb45442 into ReproNim:master Aug 29, 2023
@Remi-Gau
Copy link
Collaborator

@stebo85
Do you think that we want to add a test of installing conda on the list of all the "containers" we test?
It feels a bit silly to just install conda with no packages but if something start failing with a given distro, at least we may hear about it.

@stebo85
Copy link
Collaborator

stebo85 commented Aug 29, 2023

yes, that's a good idea. I haven't seen any issues with miniconda / mamba across different base systems, but a test for it would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants