Solving some hardcoded urls and the possibilite to use this with a admin site mapped as /`.
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobCombs
added a commit
that referenced
this pull request
Jul 20, 2012
Solving some hardcoded url`s and the possibilite to use this with a admin site mapped as `/`.
|
Looks good. thx! Also, just for some more clean up, you can just drop 'http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js' in the media class of the js dict since django ships with jquery. You can reference it in the js like this django.jQuery. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.