Skip to content

set up npm publish GitHub Action #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023
Merged

set up npm publish GitHub Action #4

merged 1 commit into from
Mar 31, 2023

Conversation

orangecms
Copy link
Collaborator

note: we need to adjust the package name first; draft for now

@orangecms orangecms force-pushed the npm-publish-action branch 2 times, most recently from 0e64bc5 to d479adb Compare March 7, 2023 16:39
@RonRadtke
Copy link
Owner

@orangecms package name and secret set up

@orangecms orangecms marked this pull request as ready for review March 27, 2023 14:11
@orangecms orangecms force-pushed the npm-publish-action branch from d479adb to 2a673db Compare March 27, 2023 14:12
@orangecms
Copy link
Collaborator Author

I have commented out running tests and build for now, left an according comment.

There is a type annotation now:

const renderRules = (Text: Component) => ({

That may break people's setup if they do not treat this as TypeScript, right?
Should we add a TypeScript build stage here, and rename the file to .tsx?

@RonRadtke
Copy link
Owner

No you don't need typescript for that. Flow works too, and react-native comes with flow support, so you can use it like this in JS files without any issues.
Not sure till which version it works but at least RN 61

@RonRadtke RonRadtke merged commit 57fb36c into master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants